Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Tenants, Instances, Tables, Segments count tiles and their respective pages #6117

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Adding Tenants, Instances, Tables, Segments count tiles and their respective pages #6117

merged 2 commits into from
Oct 7, 2020

Conversation

shahsank3t
Copy link
Contributor

Description

  1. Adding Tenants, Controllers, Brokers, Servers, Tables, Segments count on the homepage and made it clickable.
    image

  2. On clicking any cards, navigate to their respective listing page (except for Segments)
    image

  3. Added Brokers & Servers list respective of the Tenant in Tenants listing page
    image

  4. Added cursor to the hamburger menu icon to clear that it's clickable and can collapse the sidebar

  5. Made links prominently clear as clickable

@codecov-io
Copy link

Codecov Report

Merging #6117 into master will decrease coverage by 21.11%.
The diff coverage is 48.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6117       +/-   ##
===========================================
- Coverage   66.44%   45.33%   -21.12%     
===========================================
  Files        1075     1224      +149     
  Lines       54773    57779     +3006     
  Branches     8168     8528      +360     
===========================================
- Hits        36396    26192    -10204     
- Misses      15700    29439    +13739     
+ Partials     2677     2148      -529     
Flag Coverage Δ
#integration 45.33% <48.75%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ot/broker/broker/AllowAllAccessControlFactory.java 100.00% <ø> (ø)
.../helix/BrokerUserDefinedMessageHandlerFactory.java 52.83% <0.00%> (-13.84%) ⬇️
...org/apache/pinot/broker/queryquota/HitCounter.java 0.00% <0.00%> (-100.00%) ⬇️
...che/pinot/broker/queryquota/MaxHitRateTracker.java 0.00% <0.00%> (ø)
...ache/pinot/broker/queryquota/QueryQuotaEntity.java 0.00% <0.00%> (-50.00%) ⬇️
...ava/org/apache/pinot/client/AbstractResultSet.java 26.66% <0.00%> (-30.48%) ⬇️
.../main/java/org/apache/pinot/client/Connection.java 22.22% <0.00%> (-26.62%) ⬇️
.../org/apache/pinot/client/ResultTableResultSet.java 24.00% <0.00%> (-10.29%) ⬇️
...not/common/assignment/InstancePartitionsUtils.java 64.28% <ø> (-8.89%) ⬇️
.../apache/pinot/common/exception/QueryException.java 90.27% <ø> (+5.55%) ⬆️
... and 1192 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8782e47...8326038. Read the comment docs.

@kishoreg
Copy link
Member

kishoreg commented Oct 7, 2020

I think we can remove number of the segments from the tiles. It takes up a lot of time for large clusters

@shahsank3t
Copy link
Contributor Author

@kishoreg
Removed Segment Count tile.
image

@kishoreg
Copy link
Member

kishoreg commented Oct 7, 2020

Thanks, Verified that it works!

@kishoreg kishoreg merged commit 02dd3e2 into apache:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants