This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
[PIRK-19] Further restructuring in schema loading. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tellison
commented
Jul 27, 2016
tellison
commented
- Additional re-factoring of the query schema loading code.
- Pull out XML document parsing to helper methods.
- Narrowing of exception type thrown by data partitioner methods.
- Additional re-factoring of the query schema loading code. - Pull out XML document parsing to helper methods. - Narrowing of exception type thrown by data partitioner methods.
| Document doc; | ||
| try | ||
| { | ||
| DocumentBuilder dBuilder = DocumentBuilderFactory.newInstance().newDocumentBuilder(); |
There was a problem hiding this comment.
can this be made try (DocumentBuilder .....) ?
There was a problem hiding this comment.
No, the DocumentBuilder does not need to (cannot) be closed.
|
+1 |
|
Are you ready for this to be merged? |
|
@ellisonanne yes, this is ready to merge pls. There may be minor changes but this is the bulk of the clean-up restructuring I intend to do right now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.