[PIRK-53] - Fix LICENSE and NOTICE Files for Release Compliance #65
Conversation
updating fork
updating fork
updating fork
updating fork
updating fork
|
Looks ok to me, but I am no expert in legalese; I would defer to others to comment on this. |
|
If you run |
| subcomponents is subject to the terms and conditions of the following | ||
| licenses. | ||
|
|
There was a problem hiding this comment.
Just so there is no misunderstanding here, these LICENSE and NOTICE file changes are only to be included in the exe JAR, that bundles all the 3rd-party dependencies together as a convenience for the end user.
In our single project source JAR (apache-pirk-x.x.x-incubating-sources.jar), and Pirk-only binary (apache-pirk-x.x.x-incubating.jar), these LICENSE/NOTICE modifications must not appear. There will be different LICENSE and NOTICE files for the source and binary artefacts.
Ref: http://www.apache.org/dev/licensing-howto.html#bundled-vs-non-bundled
There was a problem hiding this comment.
I'm confused - how do we create different LICENSE and NOTICE files for the different jars when they are built via the release plugin?
|
Just added the licenses directory with the appropriate licenses. Please check. Thanks! |
|
Where did the |
|
Strange... it's back now. |
|
+1 looks good |
|
Just updated pom to exclude licenses during RAT checks |
|
+1 Lgtm |
ellisonanne
changed the title
| @@ -350,6 +350,9 @@ | |||
| <exclude>docs/*</exclude> <!-- Exclude docs --> | |||
| <exclude>logs/*</exclude> <!-- Exclude logs --> | |||
| <exclude>**/m2.conf</exclude> <!-- Exclude Maven conf which gets installed on travis and fails RAT check --> | |||
| <exclude>src/main/resources/META-INF/bin-license-notice/licenses/*</exclude> <!-- Exclude licenses files --> | |||
| <exclude>src/main/resources/META-INF/bin-license-notice/*</exclude> | |||
| <exclude>src/main/resources/META-INF/*</exclude> | |||
There was a problem hiding this comment.
Replace these 3 lines by a single line
<exclude>src/main/resources/META-INF/**</exclude>
|
+1 to merge, given that most of the feedback has been addressed now. |
ellisonanne
changed the title
No description provided.