Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TopicsConsumerImpl extends PartitionedConsumerImpl #1236

Closed
zhaijack opened this issue Feb 14, 2018 · 2 comments
Closed

Make TopicsConsumerImpl extends PartitionedConsumerImpl #1236

zhaijack opened this issue Feb 14, 2018 · 2 comments

Comments

@zhaijack
Copy link
Contributor

zhaijack commented Feb 14, 2018 •
edited

IN PIP-13 and its following PRs: #1103, We have made TopicsConsumerImpl behaviour similar to PartitionedConsumerImpl, This issue is tracking the following work to make dup TopicsConsumerImpl and PartitionedConsumerImpl.
@zhaijack zhaijack mentioned this issue Feb 14, 2018
Merged
@zhaijack
Copy link
Contributor Author

In the code review, @merlimat mentioned this:

I would suggest to just rename PartitionedConsumerImpl, change the constructor to accept a list of topics (rather than the number of partitions) and switch to use TopicMessageIdImpl. I don't think that UnAckedMessageTracker usage would need to be changed.

That would avoid to add a lot of new code and having to merge it later.

@zhaijack
Copy link
Contributor Author

PR #1365 handled it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhaijack