Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Itermittent test timeout on PersistentFailoverE2ETest.testSimpleConsumerEventsWithoutPartition #1614

Closed
merlimat opened this issue Apr 18, 2018 · 1 comment
Assignees

Comments

@merlimat merlimat added this to the 2.0.0-incubating milestone Apr 18, 2018
@sijie sijie self-assigned this Apr 18, 2018
@sijie
Copy link
Member

sijie commented Apr 25, 2018

discussed with @merlimat - it is a bit unknown how the flaky test can happen after spending a few days on it. so we are going to defer this to 2.1.

sijie pushed a commit that referenced this issue May 21, 2018
### Motivation

Fixes #1614 #1617 

The flaky test was actually because of a race condition in the dispatcher code. If there is a pending read when the consumer is switched, the actual switch happens after the read completes, but the dispatcher wouldn't trigger the notification at that point.

### Modifications

Ensure the active/inactive notification is sent after the read completes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants