Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubscriptionInitialPosition doesn't work with multiple-topic type subscription #2077

Closed
sijie opened this issue Jul 3, 2018 · 0 comments
Closed

SubscriptionInitialPosition doesn't work with multiple-topic type subscription #2077

sijie opened this issue Jul 3, 2018 · 0 comments
Assignees
@sijie
Labels
area/client type/bug The PR fixed a bug or issue reported a bug
Milestone
2.1.0-incubating

Comments

@sijie
Copy link
Member

sijie commented Jul 3, 2018

Expected behavior

SubscriptionInitialPosition should work for all the types of subscriptions.

Actual behavior

However it only works for one-topic subscription, it doesn't work for partitioned topic subscription, multi-topics subscription and regex subscription.

Cause

The problem is the consumer configuration is copied to an internal consumer configuration for multi-topic style subscription. but we missed copying SubscriptionInitialPosition.
@sijie sijie added type/bug The PR fixed a bug or issue reported a bug area/client labels Jul 3, 2018
@sijie sijie added this to the 2.1.0-incubating milestone Jul 3, 2018
@sijie sijie self-assigned this Jul 6, 2018
sijie added a commit to sijie/pulsar that referenced this issue Jul 6, 2018
@sijie
Issue 2077: SubscriptionInitialPosition doesn't work with multiple-to…
42b3d99 
…pic type subscription

*Motivation*

Fixes apache#2077.

The problem is the consumer configuration is copied to an internal consumer configuration for multi-topic style subscription. but we missed copying SubscriptionInitialPosition.

*Solution*

Use `clone` for popagating configuration to internal configuration.

Added a test case to cover it.
@sijie sijie mentioned this issue Jul 6, 2018
Merged
sijie added a commit that referenced this issue Jul 7, 2018
@sijie
Issue 2077: SubscriptionInitialPosition doesn't work with multiple-to…
ffe7b62 
…pic type subscription (#2100)

*Motivation*

Fixes #2077.

The problem is the consumer configuration is copied to an internal consumer configuration for multi-topic style subscription. but we missed copying SubscriptionInitialPosition.

*Solution*

Use `clone` for popagating configuration to internal configuration.

Added a test case to cover it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sijie sijie

Labels
area/client type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.1.0-incubating
Development

No branches or pull requests
1 participant
@sijie