Issue #80: Use receiveAsync() to aggregate messages into shared queue for partitioned consumer #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
merlimat
added
the
type/enhancement
sschepens
reviewed
Nov 12, 2016
| } else { | ||
| // Schedule next receiveAsync() if the incoming queue is not full. Use a different thread to avoid | ||
| // recursion and stack overflow | ||
| ForkJoinPool.commonPool().execute(() -> { |
There was a problem hiding this comment.
can't we use iothreads here?
There was a problem hiding this comment.
good point, changed that
sschepens
reviewed
Nov 12, 2016
| this.consumers = Lists.newArrayListWithCapacity(numPartitions); | ||
| this.pausedConsumers = new ConcurrentLinkedQueue<>(); | ||
| this.sharedQueueResumeThreshold = maxReceiverQueueSize / 2; |
There was a problem hiding this comment.
wouldn't it be better if the threshold was maxReceiverQueueSeize - partitions?
There was a problem hiding this comment.
having the threshold too tight would make flip-flopping easy: receiving a single message would make pausing the consumer and then when the application process it, resume the consumer. Using half-the queue size is to reduce that contention, and at the same time avoids the queue to get empty and starve the application
… queue for partitioned consumer
merlimat
force-pushed
the
issue-80-blocking-partitioned-consumer
branch
from
50adcf4
to
ff8318b
Compare
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Aug 6, 2020
Co-authored-by: yfuruta <yfuruta@yahoo-corp.jp>
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Remove the paths restrict for the CI.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Context can be found in #80. This is a slightly different approach from #83, using
receiveAsync()and pausing and resuming reads depending on the shared queue utilization.