Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ignore auth flag for websocket-proxy to broker authentication #1106

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Fix: ignore auth flag for websocket-proxy to broker authentication #1106

merged 1 commit into from
Jan 25, 2018

Conversation

rdhabalia
Copy link
Contributor

Motivation

Right now, when user wants to deploy websocket proxy which communicates to broker it requires

  • Disable client to websocket authentication by disabling authenticationEnabled flag.
  • Enable websocket proxy to broker authentication if auth-param present.
    So, websocket to broker authentication should not depend on authenticationEnabled flag.

Modifications

Remove websocket to broker auth dependency form authenticationEnabled flag.

Result

User can disable webscoket authentication and same user can enable websocket to broker authentication also.

@rdhabalia rdhabalia added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Jan 24, 2018
@rdhabalia rdhabalia added this to the 1.22.0-incubating milestone Jan 24, 2018
@rdhabalia rdhabalia self-assigned this Jan 24, 2018
merlimat
merlimat approved these changes Jan 24, 2018
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rdhabalia rdhabalia merged commit 574ebde into apache:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@rdhabalia rdhabalia

Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
1.22.0-incubating
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rdhabalia @merlimat