Log only first exception in the connection exception handler #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
rdhabalia
approved these changes
Jan 24, 2018
| log.warn("[{}] Got exception {} : {}", remoteAddress, cause.getClass().getSimpleName(), | ||
| cause.getMessage()); | ||
| } else { | ||
| log.warn("[{}] Got exception: {}", remoteAddress, cause.getMessage(), cause); |
There was a problem hiding this comment.
Instead duplicate logging logic, should we do:
log.warn("[{}] Got exception: {}", remoteAddress, cause.getMessage(), (cause instanceof NativeIoException) ? cause ? null);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After the switch to Netty-4.1, we have seen that when a connection is reset all the pending write operations are triggering a
NativeIoExceptionthat is caught and logged in theexceptionCaught()handler.If there are many topics sharing a given connection, this can print several thousand exception stacktraces for all the pending writes.
Modification