Cancel keep-alive timer task after the proxy switch to TCP proxy #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but right now, shouldn't proxy also handle client's keep-alive request on |
The proxy just passes along bytes at that point. The ping from client is just passed on to broker, which is the one that will respond. If there is a network partition either between client/proxy or proxy/broker, it will be identfied. |
|
yes, once proxy state is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After initial handshake, the Pulsar proxy switches to TCP proxy mode, by just copying buffers between the 2 connections and avoiding all parsing.
When that happens, for keep-alive messages, we rely on what the client and broker are exchanging, so they will be able to detect a stale connection client-proxy or proxy-broker.
Currently, we're not removing the keep-alive timer in the proxy, so it's forcefully closing the connection after 60s, even though client and broker are perfectly fine.