Separating configuration for client and server trust store #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h for outgoing connection to a broker
merlimat
reviewed
Feb 18, 2018
| @@ -894,6 +896,14 @@ public void setBrokerClientAuthenticationParameters(String brokerClientAuthentic | |||
| this.brokerClientAuthenticationParameters = brokerClientAuthenticationParameters; | |||
| } | |||
|
|
|||
| public String getBrokerClientTrustCertsFilePath() { | |||
There was a problem hiding this comment.
Should this default to the server trust store if empty?
There was a problem hiding this comment.
I feel it will make setting the trust store a bit complicated. Right now it is simple to set one trust store for client side and one for server.
But if you feel strongly about it - let me know I will set the default to server trust store.
There was a problem hiding this comment.
@merlimat - waiting for your reply before merging
There was a problem hiding this comment.
Sure, sounds good. We can revisit later if needed.
merlimat
added
the
type/enhancement
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the trust store used for incoming connections (Client Side) from the Outgoing (Broker Side)
We have a use case where we want to trust only a specific trust store for Client Authentication (eg. athens) but our broker certs could be signed by any other CA.
Also created new certs with 10years expiry