Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Lookup redirect logic on Proxy side #1265

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Fixed Lookup redirect logic on Proxy side #1265

merged 1 commit into from
Feb 21, 2018

Conversation

jai1
Copy link
Contributor

@jai1 jai1 commented Feb 21, 2018

During redirect we need to set response.authoritative to the new lookup otherwise the broker will send the proxy into an infinite lookup loop.

@jai1 jai1 added the type/bug The PR fixed a bug or issue reported a bug label Feb 21, 2018
@jai1 jai1 added this to the 2.0.0-incubating milestone Feb 21, 2018
@jai1 jai1 self-assigned this Feb 21, 2018
merlimat
merlimat approved these changes Feb 21, 2018
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat merged commit 3dbfb68 into apache:master Feb 21, 2018
@jai1 jai1 deleted the lookupFix branch February 21, 2018 19:37
@merlimat merlimat added this to Proposed to backport in Pulsar 1.22.1 patch Release Apr 23, 2018
@jai1 jai1 moved this from Proposed to backport to In Progress in Pulsar 1.22.1 patch Release May 2, 2018
@jai1 jai1 mentioned this pull request May 2, 2018
Merged
@jai1 jai1 moved this from In Progress to Merged for 1.22.1 in Pulsar 1.22.1 patch Release May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

Assignees

@jai1 jai1

Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
No open projects
Pulsar 1.22.1 patch Release
Merged for 1.22.1
Milestone
2.0.0-incubating
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jai1 @merlimat