BatchMessageIdImpl can be compared to MessageIdImpl #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A batch message id is a MessageIdImpl with a batchIndex >= 0. Therefore, they can be compared to MessageIdImpl. If all fields other than the batchIndex are equal to a messageId, the BatchMessageIdImpl can compare its batchIndex with -1. If it is -1, it matches the MessageIdImpl. If it is greater than -1, then it is greater than the MessageIdImpl.
merlimat
added
the
type/enhancement
sijie
pushed a commit
that referenced
this pull request
Mar 28, 2020
…nd BatchMessageId (#6621) link PR: #1285 This PR resolve the compare from BatchMessageIdImpl to MessageIdImpl, but didn't consider the symmetry on the other side. Master Issue: #6433 Motivation Fix the bug of compare between MessageId and BatchMessageId, keep the symmetry of compareTo method. Modifications In the mothod of compareTo in BatchMessageId class, when compare to non-batched messageId and other properties is equal，if batchIndex >-1, then return 1, so in MessageId class, add the same logic, and if batchIndex >-1, then return -1. Verifying this change Unit tests added.
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…nd BatchMessageId (apache#6621) link PR: apache#1285 This PR resolve the compare from BatchMessageIdImpl to MessageIdImpl, but didn't consider the symmetry on the other side. Master Issue: apache#6433 Motivation Fix the bug of compare between MessageId and BatchMessageId, keep the symmetry of compareTo method. Modifications In the mothod of compareTo in BatchMessageId class, when compare to non-batched messageId and other properties is equal，if batchIndex >-1, then return 1, so in MessageId class, add the same logic, and if batchIndex >-1, then return -1. Verifying this change Unit tests added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A batch message id is a MessageIdImpl with a batchIndex >=
0. Therefore, they can be compared to MessageIdImpl. If all fields
other than the batchIndex are equal to a messageId, the
BatchMessageIdImpl can compare its batchIndex with -1. If it is -1, it
matches the MessageIdImpl. If it is greater than -1, then it is
greater than the MessageIdImpl.