Compaction uses GetLastMessageId #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In two phase compaction, we read from the start of the topic to the end. Previously, we had no reliable way to knowing if we were at the end of the topic, so we used timeouts. However, with the new GetLastMessageId api, we can find how far we should read in a topic, and just stop when we get there.
merlimat
added
the
type/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In two phase compaction, we read from the start of the topic to the
end. Previously, we had no reliable way to knowing if we were at the
end of the topic, so we used timeouts.
However, with the new GetLastMessageId api, we can find how far we
should read in a topic, and just stop when we get there.