Schema registry 3/N #1363
Merged
Schema registry 3/N #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 12, 2018 18:09
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java # pulsar-common/src/main/java/org/apache/pulsar/common/api/Commands.java
added 18 commits
March 2, 2018 14:10
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java # pulsar-common/pom.xml
# Conflicts: # pulsar-broker/pom.xml # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaStorage.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/StoredSchema.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/proto/SchemaRegistryFormat.java # pulsar-common/src/main/java/org/apache/pulsar/common/schema/EmptyVersion.java # pulsar-common/src/main/java/org/apache/pulsar/common/schema/SchemaData.java
merlimat
reviewed
Mar 10, 2018
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * <p> |
There was a problem hiding this comment.
The <p> is failing the license check
There was a problem hiding this comment.
ok, just re-ran the formatter.
| @VisibleForTesting | ||
| public void init() throws KeeperException, InterruptedException { | ||
| try { | ||
| zooKeeper.create(SchemaPath, new byte[]{}, Acl, CreateMode.PERSISTENT); |
There was a problem hiding this comment.
Every time we do this it will actually do the write the operation on journal and then log something in zk server that it failed.
If it's very unlikely that the condition is true (just the very first time), we do and exists() call to avoid the write.
| @Override | ||
| public SchemaVersion versionFromBytes(byte[] version) { | ||
| ByteBuffer bb = ByteBuffer.wrap(version); | ||
| return new LongSchemaVersion(bb.get()); |
There was a problem hiding this comment.
get() is just reading the first byte here and ignoring the remaining 7
There was a problem hiding this comment.
Yup. Good catch. it was a type it should have been getLong() but I guess the tests pass since the version numbers tend to be low and fit within the first byte.
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Aug 26, 2020
gaoran10
pushed a commit
to gaoran10/pulsar
that referenced
this pull request
Sep 17, 2020
zymap
pushed a commit
to zymap/pulsar
that referenced
this pull request
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1137 for reference