Fix Python example class name #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Mar 22, 2018
| @@ -212,9 +212,9 @@ $ touch reverse.py | |||
| In that file, add the following: | |||
|
|
|||
| ```python | |||
| from pulsarfunction import pulsar_function | |||
| from pulsar import Function | |||
There was a problem hiding this comment.
This should not be needed
|
|
||
| class Reverse(pulsar_function.PulsarFunction): | ||
| class Reverse(Function): |
There was a problem hiding this comment.
class Reverse:
or
class Reverse(Object):
There was a problem hiding this comment.
Ah, you're right. It won't be needed in this case. I was previously using a context object in this function but decided against it.
|
|
||
| class Reverse(pulsar_function.PulsarFunction): | ||
| class Reverse(Function): | ||
| def __init__(self): |
There was a problem hiding this comment.
We can get rid of __init__ as well
merlimat
approved these changes
Mar 22, 2018
srkukarni
approved these changes
Mar 22, 2018
|
retest this please |
sijie
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python interface for Pulsar Functions has changed, and the current Pulsar Functions quick start needs to be changed to reflect this.