Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pulsar function admin api location #1423

Closed
wants to merge 1 commit into from
Closed

Refactor pulsar function admin api location #1423

wants to merge 1 commit into from

Conversation

rdhabalia
Copy link
Contributor

Motivation

Right now, pulsar-function admin api is not available.

Modifications

  • to maintain consistency of admin-api code location, move function-admin class under pulsar-admin and make pulsar-function api available under PulsarAdmin

Result

Pulsar-function admin can be accessed by PulsarAdmin.

@rdhabalia rdhabalia added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Mar 22, 2018
@rdhabalia rdhabalia added this to the 2.0.0-incubating milestone Mar 22, 2018
@rdhabalia rdhabalia self-assigned this Mar 22, 2018
@rdhabalia rdhabalia closed this Mar 22, 2018
@merlimat
Copy link
Contributor

@rdhabalia I think there was a problem with shading and dependencies to solve for this

@rdhabalia
Copy link
Contributor Author

yeah, I saw that cyclic dependency issue while bringing everything under PulsarAdmin. Will reopen if I will be able to fix it in a cleaner way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rdhabalia rdhabalia

Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.0.0-incubating
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rdhabalia @merlimat