Include DataSketches metrics provider for bookie stats #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
merlimat
added
the
type/enhancement
merlimat
force-pushed
the
master
branch
2 times, most recently
from
5b4aae2
to
42abf8c
Compare
|
@saandrews @rdhabalia Please take a look |
|
@saandrews @rdhabalia Ping again |
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Support listener either in format: type://:port, e.g.: "SSL://:9093", or in format: type://hostname:port, e.g.: "SSL://hostname:9093", For the 1st format, need to fill it with advertisedAddress for hostname. For the 2nd format, need to check the hostname is the same as advertisedAddress.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Include a metrics provider for Bookie stats for standalone and for normal cluster deployment.
We have added a new metrics provider that is based on Data Sketches that has minimal overhead (no allocations) and
dumps the stats periodically in JSON format into a file.