Fixed InvocationTargetException in pulsar-admin #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me work on that |
|
retest this please |
sijie
approved these changes
Apr 4, 2018
| @@ -71,7 +71,7 @@ | |||
| private final PersistentTopics persistentTopics; | |||
| private final NonPersistentTopics nonPersistentTopics; | |||
| private final ResourceQuotas resourceQuotas; | |||
|
|
|||
| private final ClientConfigurationData clientConfigData; | |||
There was a problem hiding this comment.
nit: better use spaces rather than tab
| public PulsarAdmin(String serviceUrl, ClientConfigurationData pulsarConfig) throws PulsarClientException { | ||
| this.auth = pulsarConfig != null ? pulsarConfig.getAuthentication() : new AuthenticationDisabled(); | ||
| public PulsarAdmin(String serviceUrl, ClientConfigurationData clientConfigData) throws PulsarClientException { | ||
| this.clientConfigData = clientConfigData; |
| */ | ||
| public ClientConfigurationData getClientConfigData() { | ||
| return clientConfigData; | ||
| } |
|
retest this please |
|
retest this please |
merlimat
approved these changes
Apr 4, 2018
|
@jai1 it seems that |
jai1
changed the title
|
replicator flaky test. retest this please |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in master:
Reason is that in
CmdFunctions.java:639we expect the admin to be an instance ofPulsarAdminWithFunctionswhilePulsarAdminBuilderImpl.build()builds an instancePulsarAdminI tried building
PulsarAdminWithFunctionsinPulsarAdminBuilderImplinstead ofPulsarAdminbut ran into lots of errors so I just commented out adding pulsar functions toPulsarAdminTool, in order to get master working since I need to develop on Admin Tools.I believe the problematic PR is 6230ab4 but can't say for sure since we use SNAPSHOT bookkeeper versions now.