Managed ledger uses ReadHandle in read path #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BookKeeper 4.6 introduced a new API for reading, called ReadHandle. This API is an small interface, unlike LedgerHandle, so it is possible to provide implementations of ReadHandle that read from sources other than bookkeeper, while presenting the same interface as when reading from bookkeeper. This patch changes the managed ledger entry read path to use ReadHandle. This is rquired to implement tiered storage (PIP-17). Master issue: 1511
|
retest this please // BrokerBkEnsemblesTests.testSkipCorruptDataLedger |
merlimat
reviewed
Apr 6, 2018
|
|
||
| checkNotNull(ml.getName()); | ||
| checkNotNull(ml.getExecutor()); | ||
| ml.getExecutor().executeOrdered(ml.getName(), safeRun(() -> { |
There was a problem hiding this comment.
As you did in some other part of code, even here we could use whenCompleteAsync() with the ml.executor().chooseThread(ml.getName()
There was a problem hiding this comment.
Didn't occur to me when I was first doing it, but done now.
To avoid creating yet another runnable.
And another merge conflict.
|
retest this please // BasicEndToEndTest.testStatsLatencies |
merlimat
added
the
type/enhancement
|
retest this please // ManagedCursorTest.cursorPersistenceAsyncMarkDeleteSameThread |
|
retest this please // ManagedCursorTest.cursorPersistenceAsyncMarkDeleteSameThread again (passes locally) & c++ test timeout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BookKeeper 4.6 introduced a new API for reading, called
ReadHandle. This API is an small interface, unlike LedgerHandle, so it
is possible to provide implementations of ReadHandle that read from
sources other than bookkeeper, while presenting the same interface as
when reading from bookkeeper.
This patch changes the managed ledger entry read path to use
ReadHandle. This is rquired to implement tiered storage (PIP-17).
Master issue: #1511