Provide unshaded pulsar-kafka-client #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sijie We should probably update the docs in |
|
@merlimat update the doc to include section how to use |
merlimat
reviewed
Apr 13, 2018
| <version>{{ site.current_version }}</version> | ||
| </dependency> | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Add explanation on which class to use. Eg:
If using this dependency, application would just need to change the Producer class from org.apache.kafka.clients.producer.KafkaProducer to org.apache.kafka.clients.producer.PulsarKafkaProducer. Similarly, the Pulsar wrapper implementation for consumer is namedPulsarKafkaConsumer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar as the original pulsar-client. It is good to provide unshaded pulsar-kafka-client, so when migrating from kafka to pulsar, there would be a change that original kafka client will be colocated with the pulsar-kafka-client. Providing an unshaded pulsar-kafka-client will address this concern.