Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix consumer redelivery should not clear availablePermits #171

Merged
merged 1 commit into from
Jan 20, 2017
Merged

Fix consumer redelivery should not clear availablePermits #171

merged 1 commit into from
Jan 20, 2017

Conversation

rdhabalia
Copy link
Contributor

Motivation

Addressing #170
For non-shared consumer: redeliverUnacknowledgedMessages() of consumer is clearing out the availablePermits which causes consumer to stop consuming messages from broker.

Modifications

consumer should increase availablePermits with number of expired messages from incomingMessages queue and sends more permits to broker if availablePermits reaches to defined threshold.

Result

Consumer will not stuck while receiving messages due to redeliverUnacknowledgedMessages().

@rdhabalia rdhabalia added the type/bug The PR fixed a bug or issue reported a bug label Jan 20, 2017
@rdhabalia rdhabalia self-assigned this Jan 20, 2017
merlimat
merlimat approved these changes Jan 20, 2017
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat added this to the 1.15.6 milestone Jan 20, 2017
@rdhabalia rdhabalia merged commit 14b6f71 into apache:branch-1.15 Jan 20, 2017
@rdhabalia rdhabalia deleted the permit-1.15 branch January 23, 2017 22:11
sijie pushed a commit to sijie/pulsar that referenced this pull request Mar 4, 2018
@srkukarni @sijie
Make Output Serde Optional (apache#171)
5f84eb1 
* Make Output Serde Optional

* Fix unittest
hangc0276 pushed a commit to hangc0276/pulsar that referenced this pull request May 26, 2021
@aloyszhang
add publish time for kafka records to enable seek offset by time (apa…
d40a1c3 
…che#172)

add publish time for kafka records to enable seek offset by time
Fix apache#171

* add publish time for kafka records to enable seek offset by time

* fix check style
@xiaotongwang1 xiaotongwang1 mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@rdhabalia rdhabalia

Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
1.15.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rdhabalia @merlimat