Unload bundle: close topic forcefully and enable bundle on ownership removal failure #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Jan 26, 2017
|
👍 |
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
Motivation Fix logrus crash, the error as follows: panic: reflect: call of reflect.Value.Type on zero Value * [Issue:173] Fix logrus crash Signed-off-by: xiaolong.ran <rxl@apache.org> * code format Signed-off-by: xiaolong.ran <rxl@apache.org> * fix a little Signed-off-by: xiaolong.ran <rxl@apache.org>
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
support create topic with configed partition number. Fix apache#173
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Apr 15, 2023
…umers when TCP/IP connections get orphaned (apache#174) upstream PR apache#20026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding patch of #164
Motivation
while unloading namespace bundle if
topic.close()fails then bundle gets stuck by staying indisablestate. Therefore, unload bundle should close topic forcefully and failure in deletion of bundle-ownership node should revert bundle state toenableback so, it can serve new topics again.Modifications
Result
bundle will not be in stuck state in case of failure in unloading namespace bundle.