Used protobuf-3.x and auto-generation for ManagedLedger and schema registry protobuf #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/enhancement
merlimat
commented
May 18, 2018
| @@ -20,7 +20,7 @@ syntax = "proto2"; | |||
|
|
|||
| package pulsar.schema; | |||
| option java_package = "org.apache.pulsar.broker.service.schema.proto"; | |||
| option optimize_for = LITE_RUNTIME; | |||
| option optimize_for = SPEED; | |||
There was a problem hiding this comment.
Change here was because LITE_RUNTIME generated code from protobuf-3x was having compile errors.
sijie
approved these changes
May 18, 2018
|
retest this please |
1 similar comment
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since ManagedLedger protobuf code was using the regular 2.4.1 protoc generated code, we can upgrade to 3.x and use maven plugin to automatically generate the Java code.