Fix REST APIs provided by Pulsar proxy #1862
Conversation
There was a problem hiding this comment.
One problem that still remains is when the service url is available.
This might be a common case when the proxy is indeed behind a load balancer (and thus have a single entry-point), but the brokers are not.
For Pulsar wire protocol, the proxy works fine since it gets the list of available brokers from ZK and it creates new connection in round-robin (unless it's targeting a specific broker).
For HTTP connection we should be doing the same, otherwise it would only work if the brokers are reachable through a load balancer.
An additional problem might also be that even though the brokers do have load balancer front, this might not be reachable from within the same network (or VPC), but only from the outside network. If the proxy is deployed in same network, it might not be able to connect to proxy.
Finally, I think we should fix this issue for 2.0.1 patch release, since right now the proxy would fail to start if the broker url is not set in proxy.conf
|
Uhm... it makes sense. |
massakam
changed the title
massakam
changed the title
|
@merlimat Modified AdminProxyHandler to handle HTTP connection in the same way as Pulsar wire protocol. Would you review again? |
Changed the milestone to 2.0.1. |
* Fix REST APIs provided by Pulsar proxy * Rename status file for test * Exclude status file from license check * Add license header to status file * Proxying HTTP request in the same way as Pulsar wire protocol
|
Backported to branch-2.0 at afa4e64 |
Motivation
The following entry points provided by Pulsar proxy does not work properly.
They always return an 404 error.
Modifications
AddedclusterNameto the proxy configuration in order to acquire a URL for proxying the http requests from configuration store servers.Modified AdminProxyHandler to get the list of active brokers from ZooKeeper and route HTTP request to one of them in round-robin.
If
brokerWebServiceURLorbrokerWebServiceURLTLSis specified in proxy.conf, proxy always routes request to that URL.The value of the existing
brokerServiceURLcan not be used, because it should be a URL that starts withpulsar://, nothttp://.Also, modified WebServer to set the context path when adding proxy servlet.
Otherwise, the requests to
/status.htmlare not handled properly by VipStatus.Result
Pulsar proxy will be able to handle the http requests to the above entry points successfully.