Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2090: Links to connector source code are broken #2092

Merged
merged 1 commit into from
Jul 7, 2018
Merged

Issue 2090: Links to connector source code are broken #2092

merged 1 commit into from
Jul 7, 2018

Conversation

sijie
Copy link
Member

@sijie sijie commented Jul 5, 2018

Motivation

Fixes #2090.

Links to connector source code are broken

Changes

  • Change package name from connect to io
  • Fix the connector class name

@sijie sijie added type/bug The PR fixed a bug or issue reported a bug doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. component/website labels Jul 5, 2018
@sijie sijie added this to the 2.1.0-incubating milestone Jul 5, 2018
@sijie sijie self-assigned this Jul 5, 2018
merlimat
merlimat approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sijie
Copy link
Member Author

sijie commented Jul 5, 2018

retest this please

1 similar comment
@sijie
Copy link
Member Author

sijie commented Jul 6, 2018

retest this please

@sijie
Issue 2090:
cac04f3 
*Motivation*

Fixes apache#2090.

Links to connector source code are broken

*Changes*

- Change package name from `connect` to `io`
- Fix the connector class name
@sijie
Copy link
Member Author

sijie commented Jul 7, 2018

retest this please

@sijie sijie merged commit 027f535 into apache:master Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@srkukarni srkukarni Awaiting requested review from srkukarni

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@jai1 jai1 Awaiting requested review from jai1

Assignees

@sijie sijie

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.1.0-incubating
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sijie @merlimat