Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patching CmdSink and adding extensive unit tests #2107

Merged
merged 12 commits into from
Jul 10, 2018
Merged

patching CmdSink and adding extensive unit tests #2107

merged 12 commits into from
Jul 10, 2018

Conversation

jerrypeng
Copy link
Contributor

No description provided.

@sijie
Copy link
Member

sijie commented Jul 7, 2018

retest this please

@jerrypeng
Copy link
Contributor Author

retest this please

2 similar comments
@jerrypeng
Copy link
Contributor Author

retest this please

@jerrypeng
Copy link
Contributor Author

retest this please

sijie
sijie approved these changes Jul 8, 2018
View reviewed changes
pulsar-client-tools/pom.xml Outdated
</goals>
<configuration>
<tasks>
<echo>building python instance</echo>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rename to something like "copy test sink package"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@jerrypeng
Copy link
Contributor Author

retest this please

@apache apache deleted a comment from sijie Jul 9, 2018
@apache apache deleted a comment from merlimat Jul 9, 2018
@jerrypeng
Copy link
Contributor Author

retest this please

2 similar comments
@jerrypeng
Copy link
Contributor Author

retest this please

@jerrypeng
Copy link
Contributor Author

retest this please

@jerrypeng
Copy link
Contributor Author

retest this please

7 similar comments
@jerrypeng
Copy link
Contributor Author

retest this please

@jerrypeng
Copy link
Contributor Author

retest this please

@jerrypeng
Copy link
Contributor Author

retest this please

@jerrypeng
Copy link
Contributor Author

retest this please

@jerrypeng
Copy link
Contributor Author

retest this please

@jerrypeng
Copy link
Contributor Author

retest this please

@jerrypeng
Copy link
Contributor Author

retest this please

@jerrypeng jerrypeng merged commit 8b206c3 into apache:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@sijie sijie sijie approved these changes

@srkukarni srkukarni Awaiting requested review from srkukarni

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jerrypeng @sijie @merlimat