fix bug in FunctionRuntimeManager involving not cleaning up old invalid assignments #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
|
rerun java8 tests |
sijie
approved these changes
Jul 25, 2018
sijie
pushed a commit
that referenced
this pull request
Aug 27, 2018
…id assignments (#2223) ### Motivation Old invalid assignments of functions are not cleaned up and left over after a function is rescheduled. Getting the status of functions rely on assignments to route the get status to the correct worker running the function. If the assignments are not correct, get status requests will be routed incorrectly. Also fixed a test that was asserting the incorrect value. The test would have caught this problem if it was asserting the correct value.
|
merged as c300e3e in branch-2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Old invalid assignments of functions are not cleaned up and left over after a function is rescheduled.
Getting the status of functions rely on assignments to route the get status to the correct worker running the function. If the assignments are not correct, get status requests will be routed incorrectly.
Also fixed a test that was asserting the incorrect value. The test would have caught this problem if it was asserting the correct value.