[client] add properties to producer for cpp & python client #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation This is a caught-up change to enable properties for producer as java clients. ### Changes Enable properties on producer for both cpp & python client ### Results Properties are added as metadata for CommandProducer. However there is no way to verify the producer properties. so I didn't add any specific tests, just adding properties for both cpp and python clients in the tests, that should excerise the corresponding code path.
merlimat
reviewed
Aug 21, 2018
| @@ -321,7 +321,8 @@ def create_producer(self, topic, | |||
| batching_max_messages=1000, | |||
| batching_max_allowed_size_in_bytes=128*1024, | |||
| batching_max_publish_delay_ms=10, | |||
| message_routing_mode=PartitionsRoutingMode.RoundRobinDistribution | |||
| message_routing_mode=PartitionsRoutingMode.RoundRobinDistribution, | |||
| properties=None, | |||
There was a problem hiding this comment.
We should add properties to the pydoc string below
srkukarni
approved these changes
Aug 21, 2018
|
@merlimat I addressed your comment. can you review it again? |
merlimat
approved these changes
Aug 22, 2018
sijie
added a commit
that referenced
this pull request
Aug 27, 2018
* [client] add properties to producer for cpp & python client ### Motivation This is a caught-up change to enable properties for producer as java clients. ### Changes Enable properties on producer for both cpp & python client ### Results Properties are added as metadata for CommandProducer. However there is no way to verify the producer properties. so I didn't add any specific tests, just adding properties for both cpp and python clients in the tests, that should excerise the corresponding code path. * Add `properties` to pydoc
|
cherry-pick as d7ec1c5 in branch-2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a caught-up change to enable properties for producer as java clients.
Changes
Enable properties on producer for both cpp & python client
Results
Properties are added as metadata for CommandProducer. However there is no way
to verify the producer properties. so I didn't add any specific tests, just
adding properties for both cpp and python clients in the tests, that should
excerise the corresponding code path.