Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enclose client_auth_params value in single quotes #2541

Closed
wants to merge 1 commit into from

Conversation

hrsakai
Copy link
Contributor

@hrsakai hrsakai commented Sep 7, 2018

Motivation

Currently, we can't specify json string to clientAuthenticationParameters in functions_worker.yaml because we can't pass it toinstance correctly.

# functions_worker.yaml
clientAuthenticationPlugin: org.apache.pulsar.client.impl.auth.AuthenticationAthenz
clientAuthenticationParameters: '{"tenantDomain":"aa"....}'

# instance process
java -cp /path/to/java-instance.jar ...... --client_auth_params {"tenantDomain":"aa"....} --use_tls false ....

Modifications

Enclose client_auth_params value in single quotes.

# process
java -cp /path/to/java-instance.jar ...... --client_auth_params '{"tenantDomain":"aa"....}' --use_tls false ....

Result

We can specify json string to clientAuthenticationParameters in functions_worker.yaml

@hrsakai hrsakai added this to the 2.2.0-incubating milestone Sep 7, 2018
@hrsakai hrsakai self-assigned this Sep 7, 2018
@hrsakai
Copy link
Contributor Author

hrsakai commented Sep 7, 2018

run java8 tests

@hrsakai
Copy link
Contributor Author

hrsakai commented Sep 7, 2018

I may have misunderstood, so I close this once.

@hrsakai hrsakai closed this Sep 7, 2018
@hrsakai hrsakai deleted the parse-json branch June 17, 2020 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant