Readd MockBookKeeper to Pulsar #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These mocks were moved out of pulsar to the bookkeeper project a few months ago. While it is good to have mocks generally available for bookkeeper, if the mock is not in the pulsar code base and we want to change the behaviour of the mock for a specific case, we need to wait for a bookkeeper release cycle to do so. It's better to have the mock in Pulsar, so we can bend it to our needs.
ivankelly
added
type/enhancement
|
Do the namespaces have to be "org.apache.bookkeeper.client"? These mocks are now Pulsar's, right? (Am I the only one who read the subject as MacBookKeeper?) |
|
@maskit it does need to be in the same package because it's not a clean mock like we would have if just mocking an interface. It relies on some package private members of the classes it is overriding unfortunately. If we can move managed ledger to completely using the new bookkeeper apis, then the mocks can go in whatever package we want. |
|
rerun integration tests |
maskit
reviewed
Sep 10, 2018
|
@maskit sure, will change it |
Also changed how error injection works, to allow more control for the caller. The caller can now ask for a promise that must be completed before a the Nth request completes. If the promise completes with an exception, that request is completed with the same exception.
|
rerun java8 tests |
sijie
approved these changes
Sep 10, 2018
maskit
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These mocks were moved out of pulsar to the bookkeeper project a few
months ago. While it is good to have mocks generally available for
bookkeeper, if the mock is not in the pulsar code base and we want to
change the behaviour of the mock for a specific case, we need to wait
for a bookkeeper release cycle to do so. It's better to have the mock
in Pulsar, so we can bend it to our needs.