close http-connection on internal server error from broker #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
By default AsyncHttpClient has Keep-alive enabled and it get connected to the bad-broker then client repeatedly fails to perform lookup requests. In that case, connection should be closed and client should be able to connect with other broker to get the request served.
eg: sometimes broker is not able to create zk-session and it keeps failing to authenticate client-request so, client should be redirected to other broker by closing client-side connection on broker's
InternalServerError
Modifications
add
KeepAliveStrategy
inhttpClient
to disable keep-alive afterinternalServerError
.Result
AsyncHttpClient
should close the connection onInternalServerError