Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed WebSocket TLS connection bug #356

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Fixed WebSocket TLS connection bug #356

merged 1 commit into from
Apr 17, 2017

Conversation

yush1ga
Copy link
Contributor

@yush1ga yush1ga commented Apr 17, 2017

Motivation

WebSocket connection is failed when using TLS connection between WebSocket proxy and broker because of the lack of some configurations.

Modifications

Added statement for configurations.

Result

WebSocket connection won't be failed.

@merlimat merlimat added the type/bug The PR fixed a bug or issue reported a bug label Apr 17, 2017
@merlimat merlimat added this to the 1.18 milestone Apr 17, 2017
merlimat
merlimat approved these changes Apr 17, 2017
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saandrews saandrews merged commit e7622f3 into apache:master Apr 17, 2017
@yush1ga yush1ga deleted the fix-websocket-tls-bug branch April 18, 2017 04:13
hrsakai pushed a commit to hrsakai/pulsar that referenced this pull request Dec 10, 2020
@wolfstudy
Add seek logic for reader (apache#356)
f9b3c0f 
Signed-off-by: xiaolong.ran <rxl@apache.org>

### Motivation


Follow apache/pulsar-client-go#222 and add the seek logic for reader 

### Modifications

- Add `seek by msgID` interface
- Add `seek by time` interface
- Add test case

### Verifying this change

- [x] Make sure that the change passes the CI checks.
hangc0276 pushed a commit to hangc0276/pulsar that referenced this pull request May 26, 2021
@dockerzhang
revert 9a4be21 to close configuring channel auto-read (apache#356)
04a648c 
revert 9a4be21, fixes apache#355
@xiaotongwang1 xiaotongwang1 mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@saandrews saandrews saandrews approved these changes

Assignees
No one assigned
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
1.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yush1ga @merlimat @saandrews