Refactor dispatcher's getting next consumer with consumer priority #367
Conversation
…teration on consumer-list
rdhabalia
added
type/bug
| do { | ||
| int priorityLevel = consumerList.get(currentConsumerRoundRobinIndex).getPriorityLevel() | ||
| - consumerList.get(resultingAvailableConsumerIndex).getPriorityLevel(); | ||
| int currentRoundRobinConsumerPriority = consumerList.get(currentConsumerRoundRobinIndex).getPriorityLevel(); |
There was a problem hiding this comment.
Should we keep getNextConsumer() as private/protected method? This and other utility method assumes we are in synchronization block. Else array location could be invalid when it changes behind the scene
There was a problem hiding this comment.
yes, updated it with private.
| */ | ||
| private int getNextConsumerFromSameOrLowerLevel(int currentRoundRobinIndex) { | ||
|
|
||
| int targetPriority = consumerList.get(currentConsumerRoundRobinIndex).getPriorityLevel(); |
There was a problem hiding this comment.
currentRoundRobinIndex instead of currentConsumerRoundRobinIndex
rdhabalia
force-pushed
the
cons_priority_simple
branch
2 times, most recently
from
ba78708
to
7f2d472
Compare
| */ | ||
| private int getNextConsumerFromSameOrLowerLevel(int currentRoundRobinIndex) { | ||
|
|
||
| int targetPriority = consumerList.get(currentRoundRobinIndex).getPriorityLevel(); |
There was a problem hiding this comment.
Can we break this into a sub method to give a consumer for a specific priority? e.g: getConsumerForPriority(priority, currentRRIndex)?
It should wrap around for that priority(if in the middle of the priority list) and return the index for available consumer or -1.
We can add a for loop for each remaining priority from currentPriority till maxPriority known to us).
Something like below:
foreach(priority = consumerList.get(currentRoundRobinIndex).getPriorityLevel(); priority<consumerList.get(consumerList.size()-1).getPriorityLevel(); priority++) {
consumerIndex = getConsumerForPriority(priority, currentRRIndex);
if( consumerIndex != -1) {
return consumerIndex;
}
}
There was a problem hiding this comment.
as we discussed: getNextConsumerFromSameOrLowerLevel checks consumer from current-level and saves the index of the next level in case we don't find consumer in the current-level and then does linear search in lower-level which is one loop so, as we discuss we will keep it in the same method.
rdhabalia
force-pushed
the
cons_priority_simple
branch
from
7f2d472
to
6dee55b
Compare
…s enabled (apache#372) Fixes apache#367 ### Motivation Send delay message individually even batching is enabled. ### Modifications 1. flush batching messages immediately when a new delay message is received 2. reset deliverAtTime metadata of `BatchBuilder`
Motivation
Refactoring #364 to have simplicity in finding next-available consumer at dispatcher by considering consumer-priority level.
Result
No functional change.