BrokerService should not remove failed topic from map with the same thread which adds in map to prevent deadlock #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
force-pushed
the
topic_load_deadlock
branch
2 times, most recently
from
2f1084f
to
23e3fdc
Compare
…hread which adds in map to prevent deadlock
rdhabalia
force-pushed
the
topic_load_deadlock
branch
from
23e3fdc
to
01de950
Compare
rdhabalia
added a commit
that referenced
this pull request
Apr 24, 2017
…hread which adds in map to prevent deadlock (#375)
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Add Pierre as the Maintainer sort name by a-z order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
while loading topic if broker-service fails to load it tries to remove topic from the map in the same thread which tries to load topic and it can create a deadlock while loading topic.
Modifications
Remove topic from concurrentMap
topicsto prevent possible deadlock.Result
It will prevent possible deadlock while loading a topic.