Shaded AsyncHttpClient in pulsar client #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Apr 28, 2017
| @@ -0,0 +1,44 @@ | |||
| com.yahoo.pulsar.shade.org.asynchttpclient.threadPoolName=AsyncHttpClient | |||
There was a problem hiding this comment.
Can you add a comment here explaining what's the purpose of this file? Same thing that you explain in the description
rdhabalia
approved these changes
Apr 29, 2017
rdhabalia
pushed a commit
that referenced
this pull request
May 2, 2017
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Currently KoP created `__consumer_offsets` repeatedly, the `ConflictException` will be thrown after apache#9342. Though it doesn't affect the usage because the `ConflictException` is treated as the concurrent issue and will be swallowed, it could cause some unnecessary logs. So this PR remove the redundant partition creation code. Another issue is that when `__consumer_offsets` already exists, the existed partition will be created because the partition returned by broker contains `persistent://` prefix but the topics in `offsetPartitionSet` don't. This PR use `KopTopic` to avoid the topic name dismatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Want to shade the asynchttpclient in pulsar-client-java since one of our customers want to use their own version of asynchttpclient. (Issue #389)
Modifications
Added asynchttpclient to maven shade plugin and created a custom properties file which is a replica on the default properties with class name shaded.
Result
We are able to provide pulsar-client-shaded.jar with asynchttpclient shaded.