Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker images definition and instruction to deploy on Kubernetes #443

Merged
merged 3 commits into from
Jun 13, 2017

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Jun 1, 2017

Motivation

Add all the configuration and instructions to do a complete deployment (zk, bookkeeper, pulsar broker and monitoring) on a Kubernetes cluster.

@merlimat merlimat added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jun 1, 2017
@merlimat merlimat added this to the 1.18 milestone Jun 1, 2017
@merlimat merlimat self-assigned this Jun 1, 2017
@merlimat
Copy link
Contributor Author

@saandrews @rdhabalia ping

@rdhabalia
Copy link
Contributor

yes, I will review it by tomorrow.

172.17.8.104 Ready 5m v1.6.4
```

The use the proxy to access the web interface :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo.?

kubectl apply -f zookeeper.yaml
```

Wait until all 3 ZK server pods are up and running. The first take will take
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first take will take

spec:
containers:
- name: bookie
image: streamlio/pulsar:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add specific tag of docker file or docker file info here because pulsar doesn't have control on this image as it may change in future which can break this setup?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we can keep streamlio/pulsar* everywhere and we can mention into ReadMe about cluster, grafana, dashboard location and customization in case one wants to change port.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, using latest is only fine for tests. The idea would be to have apache/pulsar images pushed to hub.docker.com for each release. Then we can fetch the right version when deploying.

##
## Define the Bookie headless service
## In practice, in this case, it is only useful to have a view of
## all the bookie pods that are present
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broker pods?

args:
- >
bin/apply-config-from-env.py conf/client.conf &&
sleep 10000000000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it sleep for 10000000000 msec?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to leave a pod running as admin client. Then you can attach to it and it's already configured and you can run pulsar-admin and so on.

Copy link
Contributor

@rdhabalia rdhabalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

clusterName: us-central
---
##
## Run BookKeeper auto-recovery from a different set of containers
Copy link
Contributor

@rdhabalia rdhabalia Jun 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy-paste mistake from bookie.yaml.??

@merlimat merlimat merged commit 17e6537 into apache:master Jun 13, 2017
hangc0276 pushed a commit to hangc0276/pulsar that referenced this pull request May 26, 2021
Fixes apache#332 

The offset in produce callback may be not accurate when the messages are sent in batch, see streamnative/kop#332 (comment) for detail explanation.

Since apache#9257 introduced a new API that supports fetching some metadata from the entry data, we can use this API to get the accurate offset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants