-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker images definition and instruction to deploy on Kubernetes #443
Conversation
@saandrews @rdhabalia ping |
yes, I will review it by tomorrow. |
docs/Kubernetes.md
Outdated
172.17.8.104 Ready 5m v1.6.4 | ||
``` | ||
|
||
The use the proxy to access the web interface : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo.?
docs/Kubernetes.md
Outdated
kubectl apply -f zookeeper.yaml | ||
``` | ||
|
||
Wait until all 3 ZK server pods are up and running. The first take will take |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first take will take
spec: | ||
containers: | ||
- name: bookie | ||
image: streamlio/pulsar:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add specific tag of docker file or docker file info here because pulsar doesn't have control on this image as it may change in future which can break this setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, using latest
is only fine for tests. The idea would be to have apache/pulsar
images pushed to hub.docker.com for each release. Then we can fetch the right version when deploying.
kubernetes/generic/broker.yaml
Outdated
## | ||
## Define the Bookie headless service | ||
## In practice, in this case, it is only useful to have a view of | ||
## all the bookie pods that are present |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broker pods
?
args: | ||
- > | ||
bin/apply-config-from-env.py conf/client.conf && | ||
sleep 10000000000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will it sleep for 10000000000 msec
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just to leave a pod running as admin client. Then you can attach to it and it's already configured and you can run pulsar-admin
and so on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
kubernetes/generic/broker.yaml
Outdated
clusterName: us-central | ||
--- | ||
## | ||
## Run BookKeeper auto-recovery from a different set of containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy-paste mistake from bookie.yaml.??
Fixes apache#332 The offset in produce callback may be not accurate when the messages are sent in batch, see streamnative/kop#332 (comment) for detail explanation. Since apache#9257 introduced a new API that supports fetching some metadata from the entry data, we can use this API to get the accurate offset.
Motivation
Add all the configuration and instructions to do a complete deployment (zk, bookkeeper, pulsar broker and monitoring) on a Kubernetes cluster.