Fixed message rate out with batches to count messages/s (#466) #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Jun 14, 2017
| } | ||
| }); | ||
| t1.start(); | ||
| Thread.sleep(60000); // one minute wait for stats to be updated |
There was a problem hiding this comment.
Please don't add one more minute to unit tests :)
There was a problem hiding this comment.
Reduced the sleep to two second and manually call the updateRates function.
Reducing the sleep to one second causes the rate to be shown as 0.
rdhabalia
reviewed
Jun 14, 2017
| @@ -185,8 +186,10 @@ public String consumerName() { | |||
| readChecksum(metadataAndPayload); | |||
| } | |||
|
|
|||
| MessageMetadata messageMetaData = Commands.parseMessageMetadata(metadataAndPayload); | |||
There was a problem hiding this comment.
I think we don't have to deserialize messageMetadata again. at line #160 we already know number of messages which is going to be dispatched. can we use that number?
merlimat
reviewed
Jun 14, 2017
| pulsar.getBrokerService().updateRates(); | ||
| double actualRate = admin.persistentTopics().getStats(topicName).msgRateOut; | ||
| log.info("actualRate : {}, produceRate : {}", actualRate, produceRate); | ||
| assertTrue((produceRate - 1) <= actualRate && actualRate <= (produceRate + 1)); |
There was a problem hiding this comment.
@jai1 Can you run this test multiple times to ensure is not intermittently failing?
|
@jai1 The new test is failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #466
Don't Merge yet