Package name changes #524
Closed
Package name changes #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merlimat
added a commit
that referenced
this pull request
Jun 23, 2017
merlimat
added a commit
that referenced
this pull request
Jun 23, 2017
merlimat
added a commit
that referenced
this pull request
Jun 23, 2017
merlimat
added a commit
that referenced
this pull request
Jun 23, 2017
|
(pushed with rebase to preserve individual commits) |
|
it seems last few commits of this PR were not squashed ? |
|
@rdhabalia I did not squashed them on purpose, to separate the commits with just the renaming and the commits with string changes.. So they depend on each other but better to keep them in individual commits for clarity |
|
I see.. Sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Renamed Java package names and references from
com.yahoo.pulsartoorg.apache.pulsar