Correct Kafka wrapper producer blocking semantic and passing the producer config object #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saandrews
approved these changes
Oct 17, 2017
merlimat
force-pushed
the
fix-kafka-wrapper-config
branch
from
e8d9dd0
to
3b4069f
Compare
…ucer config object
merlimat
force-pushed
the
fix-kafka-wrapper-config
branch
from
3b4069f
to
15fc2bc
Compare
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The "block when queue is full" semantic in Kafka is slightly different from the Pulsar client and we need to adjust a bit to have a comparable default setting.
Additionally, the producer config object was not passed correctly.