Allow consumer to seek to message id from within Pulsar client #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/feature
rdhabalia
reviewed
Oct 24, 2017
| @@ -1910,6 +1910,7 @@ boolean isValidPosition(PositionImpl position) { | |||
| log.debug("IsValid position: {} -- last: {}", position, last); | |||
| } | |||
|
|
|||
| // if (position.equals(PositionImpl.earliest || position.equals(PositionImpl))) | |||
There was a problem hiding this comment.
can we remove this comment.
There was a problem hiding this comment.
Ups, forgot those in there
| Consumer consumer = consumerFuture.getNow(null); | ||
| Subscription subscription = consumer.getSubscription(); | ||
| MessageIdData msgIdData = seek.getMessageId(); | ||
| // MessageIdImpl msgId = MessageIdImpl.earliest |
There was a problem hiding this comment.
can we remove this comment?
There was a problem hiding this comment.
Same, will cleanup
| try { | ||
| seekAsync(messageId).get(); | ||
| } catch (ExecutionException | InterruptedException e) { | ||
| throw new PulsarClientException(e); |
There was a problem hiding this comment.
If it's interrupted we might not have the "cause". Though I can refactor and have 2 sections here.
| }).exceptionally(ex -> { | ||
| log.warn("[{}][{}] Failed to reset subscription: {}", remoteAddress, subscription, ex.getMessage(), ex); | ||
| ctx.writeAndFlush(Commands.newError(seek.getRequestId(), ServerError.UnknownError, | ||
| "Error when resetting subscription: " + ex.getMessage())); |
There was a problem hiding this comment.
ex.getCause().getMessage()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we have the option to "reset" a subscription to a specific timestamp or message id through the Pulsar admin API.
In some cases, it might be useful to allow the same operation to be done from the
ConsumerAPI. One such example is related to the Pulsar-Kafka wrapper, in which we need to emulate operations likeseekToBeginning(),seekToEnd()orseekTo().Modifications
Added new request command in wire protocol to issue a "seek" command to the broker, relative to the subscription associated with the current consumer.