Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ConsumerHandler in WebSocket Proxy #875

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Fix ConsumerHandler in WebSocket Proxy #875

merged 1 commit into from
Nov 1, 2017
+1 −1

Conversation

yush1ga
Copy link
Contributor

@yush1ga yush1ga commented Nov 1, 2017 •
edited
Loading

Motivation

When log level is debug, receiveMessage is called although session is null and NullPointerException causes.

Modifications

Replaced getSession().getRemoteAddress() with request.getRemoteAddr() and request.getRemotePort().

Result

NullPointerException doesn't cause.

@yush1ga yush1ga added this to the 1.22.0-incubating milestone Nov 1, 2017
@yush1ga yush1ga added the type/bug The PR fixed a bug or issue reported a bug label Nov 1, 2017
@yush1ga yush1ga self-assigned this Nov 1, 2017
rdhabalia
rdhabalia approved these changes Nov 1, 2017
View reviewed changes
Copy link
Contributor

@rdhabalia rdhabalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

hrsakai
hrsakai approved these changes Nov 1, 2017
View reviewed changes
Copy link
Contributor

@hrsakai hrsakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hrsakai hrsakai merged commit 9f63fa7 into apache:master Nov 1, 2017
@hrsakai hrsakai mentioned this pull request Nov 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdhabalia rdhabalia rdhabalia approved these changes

@hrsakai hrsakai hrsakai approved these changes

Assignees

@yush1ga yush1ga

Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
1.22.0-incubating
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yush1ga @rdhabalia @hrsakai