Fix: Reset message-header index while verify checksum-strip at Reconnection #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
rdhabalia
force-pushed
the
cs_strip
branch
2 times, most recently
from
d1db08c
to
299429f
Compare
merlimat
reviewed
Oct 27, 2016
| @@ -791,9 +791,10 @@ private void resendMessages(ClientCnx cnx) { | |||
|
|
|||
| log.info("[{}] [{}] Re-Sending {} messages to server", topic, producerName, messagesToResend); | |||
|
|
|||
| final boolean stipChecksum = cnx.getRemoteEndpointProtocolVersion() < brokerChecksumSupportedVersion(); | |||
There was a problem hiding this comment.
small typo: stripChecksum
rdhabalia
added a commit
to rdhabalia/pulsar
that referenced
this pull request
Oct 27, 2016
rdhabalia
added a commit
that referenced
this pull request
Oct 28, 2016
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
* Use internal.Buffer() for message metadata parsing * Fixed test
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
At reconnection: before resending messages, producer verifies broker-version and removes checksum and modifies prepared message if requires. If message is not modified then message-header index is not reset correctly which can corrupt the message.
This problem would only happen in a mixed environment with 1.15 and 1.14 clients.
Modifications
Reset message-header index while stripping checksum.
Result
It will not corrupt message while resending message on reconnection.