Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 924: Provide a json file for Marathon app groups to run Pulsar on DCOS #950

Merged
merged 3 commits into from
Dec 16, 2017

Conversation

zhaijack
Copy link
Contributor

@zhaijack zhaijack commented Dec 7, 2017

Motivation

There was a requirement to run Pulsar on DCOS in #917 , but Universe Package is not support well now. this is to create a json file for Marathon app groups to run Pulsar on DCOS.

Modifications

add a json file to deploy pulsar as a Marathon group on DCOS.

Result

could use command dcos marathon group add PulsarGroups.json to deploy Pulsar on DCOS.

Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhaijack can you provide a README on how to use this json file? or maybe instructions on how to run it, and how to verify the setup?

@zhaijack
Copy link
Contributor Author

zhaijack commented Dec 8, 2017

@sijie. It just need one cli command to do the deploy dcos marathon group add PulsarGroups.json, adding a page to make this more clear for this deploy.

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice work!

@lucperkins Can you give an eye to the new doc page?

@zhaijack
Copy link
Contributor Author

seems picture on website not auto fill the browser window, opened issue #951 tracking the picture show issue.

Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lucperkins
Copy link
Contributor

@zhaijack The content of the doc looks great! I think it could use some reworking from a native speaker, but I'll do that in a separate PR. Ship it!

@merlimat
Copy link
Contributor

retest this please

@merlimat merlimat added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Dec 15, 2017
@merlimat merlimat added this to the 1.22.0-incubating milestone Dec 15, 2017
@merlimat merlimat merged commit 6e7b712 into apache:master Dec 16, 2017
"type": "DOCKER",

"docker": {
"image": "zhaijia/prometheus",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any thing additional present into docker image compare to https://hub.docker.com/r/prom/prometheus/ ? If not then should we replace it with prom/prometheus/?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the configuration file is special for DC/OS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then should we we add docker file in this repo and push image under apachepulsar?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @rdhabalia suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants