-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 924: Provide a json file for Marathon app groups to run Pulsar on DCOS #950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhaijack can you provide a README on how to use this json file? or maybe instructions on how to run it, and how to verify the setup?
@sijie. It just need one cli command to do the deploy dcos marathon group add PulsarGroups.json, adding a page to make this more clear for this deploy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice work!
@lucperkins Can you give an eye to the new doc page?
seems picture on website not auto fill the browser window, opened issue #951 tracking the picture show issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@zhaijack The content of the doc looks great! I think it could use some reworking from a native speaker, but I'll do that in a separate PR. Ship it! |
retest this please |
"type": "DOCKER", | ||
|
||
"docker": { | ||
"image": "zhaijia/prometheus", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any thing additional present into docker image compare to https://hub.docker.com/r/prom/prometheus/
? If not then should we replace it with prom/prometheus/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the configuration file is special for DC/OS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then should we we add docker file in this repo and push image under apachepulsar
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to @rdhabalia suggested.
Motivation
There was a requirement to run Pulsar on DCOS in #917 , but Universe Package is not support well now. this is to create a json file for Marathon app groups to run Pulsar on DCOS.
Modifications
add a json file to deploy pulsar as a Marathon group on DCOS.
Result
could use command
dcos marathon group add PulsarGroups.json
to deploy Pulsar on DCOS.