This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
fixes bug in ordering of cmds #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hbdeshmukh This one will be good to have in before the next release candidate. |
|
Are there any issues with Travis? None of the recent PRs have been scheduled yet. I would like to merge the three PRs related to RC6 without waiting for the Travis to complete. Partly because the changes are small and are verified by @cramja on his laptop and also because they are necessary for the preparation towards release. Any objections? |
|
@cramja Can you please rebase your branch with the master? I can merge it. |
|
I have no objections ;) |
cramja
force-pushed
the
modify-release-scripts
branch
from
17139ce
to
7427a4b
Compare
zuyu
reviewed
Mar 4, 2017
| @@ -25,6 +25,7 @@ create_artifacts() { | |||
|
|
|||
| export RELEASE_DIR=`pwd` | |||
| cd .. | |||
| export BASE_DIR=`pwd` | |||
There was a problem hiding this comment.
Curious: any difference in value between $BASE_DIR and $RELEASE_DIR?
There was a problem hiding this comment.
$BASE_DIR is the quickstep root. release dir is $BASE_DIR/release
cramja
force-pushed
the
modify-release-scripts
branch
from
7427a4b
to
04dd947
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bugfixes to the release scripts. Previously I was saving the wrong directories to environment variables. Also, adding grep to one of the commands makes it work predictably.