This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
Removed unused argument always_mark_full. #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuyu
force-pushed
the
always-mark-full-arg
branch
from
f4c27de
to
8e2cc08
Compare
hbdeshmukh
reviewed
Oct 10, 2017
| @@ -104,7 +104,7 @@ class InsertDestinationInterface { | |||
| * insertion from ValueAccessor even when partially full. | |||
| **/ | |||
| virtual void bulkInsertTuples(ValueAccessor *accessor, | |||
| bool always_mark_full = false) = 0; | |||
| const bool always_mark_full = false) = 0; | |||
There was a problem hiding this comment.
Similar to other variants of bulkInsert methods, why are we not getting rid of the always_mark_full parameter in this function?
There was a problem hiding this comment.
It is required by the first pass of the multi-pass sort.
|
Looks good. |
zuyu
force-pushed
the
always-mark-full-arg
branch
from
8e2cc08
to
f820c45
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the unused argument
always_mark_full, and avoids branching overhead.