Skip to content
This repository has been archived by the owner on Feb 8, 2019. It is now read-only.

Support Multiple Tuple Inserts #320

Merged
merged 1 commit into from Oct 25, 2017

Conversation

robertclaus
Copy link
Contributor

Added support for multiple tuple insert.

Previously

INSERT INTO <table> VALUES (<values for tuple 1>),(<values for tuple 2>);

would not work. With this change it will insert both tuples into <table>.

@asfgit asfgit merged commit 0fe838d into apache:master Oct 25, 2017
@zuyu
Copy link
Member

zuyu commented Oct 26, 2017

IMHO, this PR has a major design issue where for multi-tuple insertions, we create a bunch of InsertOperator and SaveBlocksOperator, each for tuple.

@hbdeshmukh
Copy link
Contributor

I agree with @zuyu. We should reconsider the design.

@jianqiao
Copy link
Contributor

It may just be fine before ExecutionGenerator, I think the fix is to revise ExecutionGenerator::convertInsertTuple() and do some modifications inside InsertOperator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants