Skip to content
This repository has been archived by the owner on Feb 8, 2019. It is now read-only.

QUICKSTEP-113 Remove glog source code from third party #327

Merged
merged 1 commit into from Dec 21, 2017
Merged

QUICKSTEP-113 Remove glog source code from third party #327

merged 1 commit into from Dec 21, 2017

Conversation

hbdeshmukh
Copy link
Contributor

  • glog source code is now downloaded through the download script.
  • Added patches for glog.

@hbdeshmukh
Copy link
Contributor Author

In the past we had some issues with glog and xCode. Can someone volunteer to test this change using xCode?

cc: @jianqiao @pateljm

@hbdeshmukh hbdeshmukh changed the title Remove glog source code from third party QUICKSTEP-113 Remove glog source code from third party Dec 15, 2017
@hbdeshmukh
Remove glog source code from third party
c43107d 
- glog source code is now downloaded through the download script.
- Added patches for glog.
@zuyu
Copy link
Member

zuyu commented Dec 19, 2017

It works on Mac, but I have not tested using XCode.

@jianqiao
Copy link
Contributor

I have tested Xcode, it works! Will merge the PR later.

@jianqiao
Copy link
Contributor

Merging.

@asfgit asfgit merged commit c43107d into apache:master Dec 21, 2017
@hbdeshmukh hbdeshmukh deleted the glog-upgrade branch January 3, 2018 21:08
@zuyu
Copy link
Member

zuyu commented Feb 1, 2018

Hi @hbdeshmukh,

This PR that uses glog 0.3.5 has a side effect that does not catch before: it requires cmake version 3.0, but the default cmake version in Ubuntu 14.04 LTS is 2.8.12.2.

@hbdeshmukh
Copy link
Contributor Author

Thanks for catching this issue @zuyu. I will create a PR to bump up Quickstep's minimum cmake version.

@hbdeshmukh hbdeshmukh mentioned this pull request Apr 2, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@hbdeshmukh @zuyu @jianqiao @asfgit