RATIS-969. Add flatbuffers to Ratis thirdparty. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokeshj1703
reviewed
Jun 9, 2020
There was a problem hiding this comment.
@mukul1987 Thanks for working on this! The changes look good to me. One minor comment. We might need to update META-INF/NOTICE file with the copyright information for flatbuffers.
lokeshj1703
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
@mukul1987 Thanks for updating the PR! The changes look good to me. +1.
|
@mukul1987 Thanks for the contribution! I have committed the PR to master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache jira:
https://issues.apache.org/jira/browse/RATIS-969
This PR adds flat buffers to Ratis Third party.
References:-
https://google.github.io/flatbuffers/
https://en.wikipedia.org/wiki/FlatBuffers