New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RATIS-940. Add sonar check for ratis #108
Conversation
@elek Could I request your quick review as you had done the similar changes in Ozone? |
Checkstyle failure is unrelated to the PR. ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/LogSegment.java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM Thanks to drive this effort @dineshchitlangia
GITHUB_TOKEN is not required in the env section as far as I know, but doesn't cause any problem.
Can be removed if you merge it locally and push it...
@elek Thank you for the review. You are right the Github token is not needed when merging/pushing locally. As we are slowly moving towards merging directly via GitHub PRs this will be needed, at least as per Sonar's documentation :) Let me know if you can commit this or you want me to drop the github token. |
Ok, thanks. Good to know. In that case, let me merge it. |
Thanks @elek for review/commit. I confirmed we are able to see the Sonar analyses : https://sonarcloud.io/dashboard?id=apache_incubator-ratis I will create an action plan / umbrella Jira to fix all of these and we should be in a clean state soon. |
Wow. Great work. |
Ratis instance has been created in ASF's Sonar Cloud. This can now be used to analyze and improve the code quality. To ensure the analysis is automatically executed whenever there is a commit in master branch, we need to add a github action for Sonar check.
This PR aims to do that.
https://issues.apache.org/jira/browse/RATIS-940
For testing, I was able to add a token in my fork on incubator-ratis and confirm the script triggers analysis. For the incubator-ratis repo, ASF INFRA team helped to add the sonar cloud token in the repo settings via https://issues.apache.org/jira/browse/INFRA-20295
Once this PR is merged, I can confirm that the sonar check got enabled correctly.